Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in build.rs to fix builds with Rust 1.73+ #16

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix typo in build.rs to fix builds with Rust 1.73+ #16

merged 1 commit into from
Oct 24, 2023

Conversation

decathorpe
Copy link
Contributor

This PR fixes a typo in the build script that causes a build failure with Rust 1.73+:

Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

@puiterwijk
Copy link
Owner

Thanks!

@7flying 7flying mentioned this pull request Oct 11, 2023
Merged
@7flying
Copy link

7flying commented Oct 11, 2023

Just another interested party in seeing this PR merged

@7flying 7flying mentioned this pull request Oct 11, 2023
Closed
@decathorpe
Copy link
Contributor Author

Note that I've already included this patch in the package for the openssl-kdf crate in Fedora, so builds of Fedora packages that don't use vendored dependencies are already not affected.

@puiterwijk puiterwijk merged commit 1191753 into puiterwijk:main Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puiterwijk puiterwijk puiterwijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decathorpe @puiterwijk @7flying